Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marcosertoli/st40 cleanup #296

Merged
merged 17 commits into from
Nov 15, 2023
Merged

Marcosertoli/st40 cleanup #296

merged 17 commits into from
Nov 15, 2023

Conversation

marcosertoli
Copy link
Contributor

Large clean-up deleting all unused things from the st40 branch and moving development files to a dedicated folder.

@marcosertoli
Added development directory to hold files still under development but…
f3093f7 
… potentially useful to the user group.
@marcosertoli
Modified tomo_1D.py to be aesthetically more in line with the rest of…
2e12a47 
… the plotting.
@marcosertoli
Deleted unused plotting methods
a8390a5
@marcosertoli
Clean-up of st40 branch approaching move to indica-mcf organisation
62fac27
@marcosertoli
Renamed test for abstract reader
c5b7922
@marcosertoli
Deleting all unused stuff in st40 branch
52fd84b
@marcosertoli
Wrapper to build centrifugal asymmetry parameters and profiles in Ind…
50278ef 
…ica native DataArray format
@marcosertoli
Slow but working version of inversion including asymmetry
9bac848
@marcosertoli
Making tangential as default bolometer geometry. TODO: make general g…
4e46bb9 
…eometry sets to be used across models.
@marcosertoli
Modified centrifugal_asymmetry.py to accept profiles without t dimension
ec39496
@marcosertoli
Residuals must be residuals, with a sign
6c2cc07
@marcosertoli
Removed tomo_asymmetry.py to be pushed to a separate branch
16f2c15
@marcosertoli
Moved surf_los.dat in data folder and ran pre-commit
ef590a6
@marcosertoli
Changed name of spline_fit_easy.py to simply spline_fit.py
e1a8c39
@marcosertoli
Reinstated asymmetry tomography because of dependencies.
b2deee5
@marcosertoli
Reinstated asymmetry tomography because of dependencies and cleaned u…
69c9c5e 
…p implementation.
@marcosertoli marcosertoli marked this pull request as ready for review November 2, 2023 12:58
@marcosertoli
Copy link
Contributor Author

Included also a standalone draft 2D "tomography" inference with poloidal asymmetry capabilities.
Apart from this, it's really just a cleanup of stuff that's not used, in view of making the ST40 branch more easily browsable and understandable.

@michael-gemmell michael-gemmell merged commit 6dcbb80 into st40 Nov 15, 2023
2 of 3 checks passed
@michael-gemmell michael-gemmell deleted the marcosertoli/st40_cleanup branch November 15, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-gemmell michael-gemmell michael-gemmell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosertoli @michael-gemmell